Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

djangorestframework-jwt: init at 1.11.0 #53698

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
3 participants
@ivegotasthma
Copy link
Contributor

ivegotasthma commented Jan 9, 2019

Motivation for this change

I'm packaging this python library because I want to use nix-shell to manage python dependencies for a project.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

dotlambda left a comment

Adding yourself to maintainer-list.nix should be a separate commit.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 13, 2019

@ivegotasthma ivegotasthma force-pushed the ivegotasthma:master branch from 84a74c4 to 7594055 Jan 17, 2019

@ivegotasthma ivegotasthma force-pushed the ivegotasthma:master branch 2 times, most recently from e2d5d52 to 2b21d9a Jan 18, 2019

@ivegotasthma

This comment has been minimized.

Copy link
Contributor Author

ivegotasthma commented Jan 18, 2019

@dotlambda Yes, I've read the python manual.

@dotlambda
Copy link
Member

dotlambda left a comment

Why are you adding django-rest-auth without referencing it in python-packages.nix?

Also, please make sure the commit which adds you to the maintainer list is the first one.

@ivegotasthma ivegotasthma force-pushed the ivegotasthma:master branch from 2b21d9a to 0e1bd17 Jan 18, 2019

@ivegotasthma

This comment has been minimized.

Copy link
Contributor Author

ivegotasthma commented Jan 18, 2019

@dotlambda I accidentally added the django-rest-auth module. Can I submit more than 1 module at once?

@ivegotasthma ivegotasthma force-pushed the ivegotasthma:master branch from 0e1bd17 to 9b49321 Jan 18, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 18, 2019

@dotlambda I accidentally added the django-rest-auth module. Can I submit more than 1 module at once?

If it makes sense to, e.g. if these are all required for a certain package you're packaging, you should put these commits in a single PR.

@ivegotasthma

This comment has been minimized.

Copy link
Contributor Author

ivegotasthma commented Jan 20, 2019

I'll close this and open a second PR later on with all the other modules I'll need.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 21, 2019

Please ping me when you did so.

@ivegotasthma

This comment has been minimized.

Copy link
Contributor Author

ivegotasthma commented Jan 21, 2019

@dotlambda I have a package that doesn't include tests in the pypi release, is it a better practice to package the testless pypi or the github release that includes tests?

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 21, 2019

If you plan on actively maintaining it, I think there's no harm in fetching from GitHub. Otherwise, PyPI is preferred because it allows for auto-upgrades. Best would be to file an upstream PR or issue so they include the tests in their PyPI tarball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.