Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib: fix libgio segfaults #53714

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Jan 9, 2019

In particular this fixes the libmediaart tests.

closes #53701

Built libmediaart successfully on x86_linux.

In particular this fixes the libmediaart tests.

closes NixOS#53701
@@ -70,6 +70,11 @@ stdenv.mkDerivation rec {
url = https://gitlab.gnome.org/GNOME/glib/commit/85c4031696add9797e2334ced20678edcd96c869.patch;
sha256 = "1hmyvhx89wip2a26gk1rvd87k0pjfia51s0ysybjyzf5f1pzw877";
})
# https://gitlab.gnome.org/GNOME/glib/issues/1645
(fetchpatch {
url = https://gitlab.gnome.org/GNOME/glib/commit/e695ca9f310c393d8f39694f77471dbcb06daa9e.diff;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not?

Suggested change
url = https://gitlab.gnome.org/GNOME/glib/commit/e695ca9f310c393d8f39694f77471dbcb06daa9e.diff;
url = https://gitlab.gnome.org/GNOME/glib/commit/e695ca9f310c393d8f39694f77471dbcb06daa9e.patch;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just hit the plain diff button. Not sure if it's worth the ofborg cycles though tbh 😆

@hedning
Copy link
Contributor Author

hedning commented Jan 9, 2019

@GrahamcOfBorg build libmediaart

@7c6f434c 7c6f434c merged commit 61e13f7 into NixOS:staging Jan 10, 2019
@hedning hedning deleted the fix-libgio-segfaults branch October 15, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants