Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib: fix libgio segfaults #53714

Merged
merged 1 commit into from Jan 10, 2019

Conversation

@hedning
Copy link
Contributor

commented Jan 9, 2019

In particular this fixes the libmediaart tests.

closes #53701

Built libmediaart successfully on x86_linux.

glib: fix libgio segfaults
In particular this fixes the libmediaart tests.

closes #53701
@@ -70,6 +70,11 @@ stdenv.mkDerivation rec {
url = https://gitlab.gnome.org/GNOME/glib/commit/85c4031696add9797e2334ced20678edcd96c869.patch;
sha256 = "1hmyvhx89wip2a26gk1rvd87k0pjfia51s0ysybjyzf5f1pzw877";
})
# https://gitlab.gnome.org/GNOME/glib/issues/1645
(fetchpatch {
url = https://gitlab.gnome.org/GNOME/glib/commit/e695ca9f310c393d8f39694f77471dbcb06daa9e.diff;

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Jan 9, 2019

Member

Why not?

Suggested change
url = https://gitlab.gnome.org/GNOME/glib/commit/e695ca9f310c393d8f39694f77471dbcb06daa9e.diff;
url = https://gitlab.gnome.org/GNOME/glib/commit/e695ca9f310c393d8f39694f77471dbcb06daa9e.patch;

This comment has been minimized.

Copy link
@hedning

hedning Jan 9, 2019

Author Contributor

Ah, I just hit the plain diff button. Not sure if it's worth the ofborg cycles though tbh 😆

@hedning

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2019

@GrahamcOfBorg build libmediaart

@7c6f434c 7c6f434c merged commit 61e13f7 into NixOS:staging Jan 10, 2019

13 of 16 checks passed

nix-build -A glib --argstr system x86_64-darwin Build Results
Details
nix-build -A libmediaart --argstr system aarch64-linux Build Results
Details
nix-build -A libmediaart --argstr system x86_64-darwin Build Results
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A glib --argstr system aarch64-linux Build Results
Details
nix-build -A glib --argstr system x86_64-linux Build Results
Details
nix-build -A libmediaart --argstr system x86_64-linux Build Results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.