New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

termbox: fix build #53722

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
5 participants
@Ma27
Copy link
Member

Ma27 commented Jan 10, 2019

Motivation for this change

Applies a patch which fixes the waf build on Python 3.7.
See also https://hydra.nixos.org/build/86295267

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27

This comment has been minimized.

Copy link
Member

Ma27 commented Jan 10, 2019

Pinging @fgaz, the maintainer of this package to test.

termbox: fix build
Applies a patch which fixes the `waf` build on Python 3.7.
See also https://hydra.nixos.org/build/86295267

@Ma27 Ma27 force-pushed the Ma27:fix-python37-on-termbox branch from ffbb183 to d50dacb Jan 10, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Jan 10, 2019

This fixes the build, but shouldn't a python module use buildPythonPackage?

Though that's outside the scope of this pr.

@Ma27

This comment has been minimized.

Copy link
Member

Ma27 commented Jan 10, 2019

I'd say no in this case. buildPython{Package.Application} is designed to create a Python package using setuptools to build. In this case waf is used. However I'm not entirely sure whether it fits into pythonPackages, but that's out of scope IMHO.

@fgaz

fgaz approved these changes Jan 11, 2019

Copy link
Contributor

fgaz left a comment

lgtm

@fgaz

This comment has been minimized.

Copy link
Contributor

fgaz commented Jan 11, 2019

@Ma27

I'm not entirely sure whether it fits into pythonPackages

This only builds the C library, so no

@Mic92 Mic92 merged commit ce9bc1e into NixOS:master Jan 11, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@Ma27 Ma27 deleted the Ma27:fix-python37-on-termbox branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment