Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pika-pool: fix build #53723

merged 1 commit into from
Jan 10, 2019


Copy link

@Ma27 Ma27 commented Jan 10, 2019

Motivation for this change

Loosen version constraint to allow current pika as well (currently
0.12). See also

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

Loosen version constraint to allow current `pika` as well (currently
0.12). See also
Copy link

This is a reported issue too bninja/pika-pool#17.

Copy link

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds locally. hopefully this functions with the newer pika.

Copy link
Member Author

Ma27 commented Jan 10, 2019

Did some basic tests with the library, let's hope that's sufficient :)

@worldofpeace worldofpeace merged commit fc24e42 into NixOS:master Jan 10, 2019
@Ma27 Ma27 deleted the fix-python37-pika-pool branch January 10, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants