New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pika-pool: fix build #53723

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@Ma27
Copy link
Member

Ma27 commented Jan 10, 2019

Motivation for this change

Loosen version constraint to allow current pika as well (currently
0.12). See also https://hydra.nixos.org/build/86116480

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

python3Packages.pika-pool: fix build
Loosen version constraint to allow current `pika` as well (currently
0.12). See also https://hydra.nixos.org/build/86116480
@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Jan 10, 2019

This is a reported issue too bninja/pika-pool#17.

@worldofpeace
Copy link
Member

worldofpeace left a comment

Builds locally. hopefully this functions with the newer pika.

@Ma27

This comment has been minimized.

Copy link
Member Author

Ma27 commented Jan 10, 2019

Did some basic tests with the library, let's hope that's sufficient :)

@worldofpeace worldofpeace merged commit fc24e42 into NixOS:master Jan 10, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@Ma27 Ma27 deleted the Ma27:fix-python37-pika-pool branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment