Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thrift: fix build #53726

Merged
merged 2 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@Ma27
Copy link
Member

commented Jan 10, 2019

Motivation for this change

Fixes the build of thrift (and pycassa) by specifying proper constraints and adding missing dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pythonPackages.thrift: fix build
Adds missing `six` dependency to the build inputs.

See also https://hydra.nixos.org/build/86094652
@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

The pin was to fix pycassa/pycassa#245.

@Ma27

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2019

Although I can't reproduce the issue in the manual example with list_keyspaces with a local cassandra instance, I guess it's better to not break the constraint then. Should we simply override thrift in the pycassa expression accordingly?

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

Although I can't reproduce the issue in the manual example with list_keyspaces with a local cassandra instance, I guess it's better to not break the constraint then. Should we simply override thrift in the pycassa expression accordingly?

I think we should do that, though there's usually not much else we can do with these kind of issues.

pythonPackages.pycassa: fix build
Use `thrift` 0.9.3 to build.

See also pycassa/pycassa#245

@Ma27 Ma27 force-pushed the Ma27:unbreak-thrift branch from 461cfd2 to 642f778 Jan 10, 2019

@Ma27

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2019

@worldofpeace fixed and tested with a local cassandra instance. Anything else to add? :)

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

@worldofpeace fixed and tested with a local cassandra instance. Anything else to add? :)

Nope, looks great. Built it locally with success.

@worldofpeace worldofpeace merged commit 3bcd4f3 into NixOS:master Jan 10, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@Ma27 Ma27 deleted the Ma27:unbreak-thrift branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.