/nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hexyl: init at 0.3.0 #53728

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Reviewers

@jb55 jb55

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 8.has: package (new)
Projects
None yet
Milestone
No milestone
4 participants
@lilyball @jb55 @dywedir @GrahamcOfBorg
@lilyball
Copy link
Contributor

lilyball commented Jan 10, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I left the maintainers empty as I don't particularly want to be on the hook for keeping this up-to-date. I'm hoping @dywedir will consent to maintain it as they already maintain the similar fd and bat packages by the same author.
@lilyball
hexyl: init at 0.3.0
Loading status checks…
96bffeb

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 10, 2019

@jb55

This comment has been minimized.

Sign in to view
Copy link
Contributor

jb55 commented Jan 10, 2019

I was almost done packaging this xD. you people are too fast
@jb55

jb55 approved these changes Jan 10, 2019
View changes

@lilyball

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

lilyball commented Jan 10, 2019

It looks like the next version of hexyl will support Windows: sharkdp/hexyl#15
@lilyball

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

lilyball commented Jan 10, 2019

v0.3.1 is expected to be released tonight. I'll update this PR tomorrow unless a repo maintainer gets to it first.
@lilyball

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

lilyball commented Jan 10, 2019

Or I suppose this could be merged and a new PR opened for v0.3.1.
@dywedir

This comment has been minimized.

Sign in to view
Copy link
Contributor

dywedir commented Jan 10, 2019 •
edited

Thank you!

@GrahamcOfBorg build hexyl

@dywedir dywedir merged commit 63ffed1 into NixOS:master Jan 10, 2019
10 checks passed

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@dywedir

This comment has been minimized.

Sign in to view
Copy link
Contributor

dywedir commented Jan 10, 2019 •
edited 

v0.3.1

@sharkdp released this a minute ago

😄

@lilyball lilyball deleted the lilyball:hexyl branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment