Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgsanity: init at 0.2.9 #53733

Merged
merged 1 commit into from
Jan 10, 2019
Merged

pgsanity: init at 0.2.9 #53733

merged 1 commit into from
Jan 10, 2019

Conversation

nalbyuites
Copy link
Contributor

@nalbyuites nalbyuites commented Jan 10, 2019

Motivation for this change

Requested by Joachim Schiele js@lastlog.de

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nalbyuites
Copy link
Contributor Author

nox-review output attached.

Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor notices

pkgs/development/python-modules/pgsanity/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pgsanity/default.nix Outdated Show resolved Hide resolved
@Ma27
Copy link
Member

Ma27 commented Jan 10, 2019

@GrahamcOfBorg build pythonPackages.pgsanity python3Packages.pgsanity

@Ma27
Copy link
Member

Ma27 commented Jan 10, 2019

The patch looks good now, thanks. Please squash your commits into a single commit and name it like pythonPackages.pgsanity: init at 0.2.9 as described in the contribution guidelines.

@nalbyuites
Copy link
Contributor Author

The patch looks good now, thanks. Please squash your commits into a single commit and name it like pythonPackages.pgsanity: init at 0.2.9 as described in the contribution guidelines.

I have done this now. Thank you for guiding me!

@Ma27 Ma27 merged commit b936b2d into NixOS:master Jan 10, 2019
@Ma27
Copy link
Member

Ma27 commented Jan 10, 2019

@nalbyuites thanks!

@nalbyuites nalbyuites deleted the pgsanity branch January 10, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants