Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgsanity: init at 0.2.9 #53733

Merged
merged 1 commit into from Jan 10, 2019

Conversation

@nalbyuites
Copy link
Contributor

commented Jan 10, 2019

Motivation for this change

Requested by Joachim Schiele js@lastlog.de

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nalbyuites

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

nox-review output attached.

@Ma27
Copy link
Member

left a comment

Some minor notices

@Ma27

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

@GrahamcOfBorg build pythonPackages.pgsanity python3Packages.pgsanity

@Ma27

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

The patch looks good now, thanks. Please squash your commits into a single commit and name it like pythonPackages.pgsanity: init at 0.2.9 as described in the contribution guidelines.

@nalbyuites nalbyuites force-pushed the nalbyuites:pgsanity branch from 6ea4f56 to 0633925 Jan 10, 2019

@nalbyuites

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

The patch looks good now, thanks. Please squash your commits into a single commit and name it like pythonPackages.pgsanity: init at 0.2.9 as described in the contribution guidelines.

I have done this now. Thank you for guiding me!

@Ma27 Ma27 merged commit b936b2d into NixOS:master Jan 10, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Ma27

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

@nalbyuites thanks!

@nalbyuites nalbyuites deleted the nalbyuites:pgsanity branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.