New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk3: fix segfaults when opening dialogs #53736

Closed
wants to merge 1 commit into
base: staging
from

Conversation

Projects
None yet
4 participants
@hedning
Copy link
Contributor

hedning commented Jan 10, 2019

Apply upstream fix.

closes #53697

@hedning

This comment has been minimized.

Copy link
Contributor Author

hedning commented Jan 10, 2019

Would it be viable to target master, it's a big (7000 all platforms combined) rebuild, but not massive? The bug is quite bad, crashing at least firefox, thunderbird and emacs reliably.

@vcunat

This comment has been minimized.

Copy link
Member

vcunat commented Jan 10, 2019

For some reason the crashes don't happen to me (current master 829ada3; perhaps because of WM or something). Have you tested this really fixes the problems for you?

@hedning

This comment has been minimized.

Copy link
Contributor Author

hedning commented Jan 10, 2019

I'm going off @Mic92's bug report, which matches the upstream issue well: https://gitlab.gnome.org/GNOME/gtk/issues/1523

I haven't tested it myself, but yeah, if it's not happening consistently staging is probably fine.

@vcunat

This comment has been minimized.

Copy link
Member

vcunat commented Jan 10, 2019

So far no "luck" for me (no crash): I've tried xfwm4, xmonad, firefox, thunderbird, intel IGPU, AMD GPU.

@hedning

This comment has been minimized.

Copy link
Contributor Author

hedning commented Jan 10, 2019

Should be fine to pass this through staging then, we can always fast forward it's needed later.

@vcunat

This comment has been minimized.

Copy link
Member

vcunat commented Jan 10, 2019

In any case, you forgot to fix the copy-pasted hash ;-)

@hedning

This comment has been minimized.

Copy link
Contributor Author

hedning commented Jan 10, 2019

Ouch, thanks.

@hedning hedning force-pushed the hedning:fix-gtk3-segfaults branch from 73540dc to f671ec8 Jan 10, 2019

vcunat added a commit that referenced this pull request Jan 10, 2019

@vcunat

This comment has been minimized.

Copy link
Member

vcunat commented Jan 10, 2019

Hydra's basically idle ATM, but let's compromise on staging-next for now: 2712f12

@hedning hedning closed this Jan 10, 2019

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Jan 10, 2019

That fixed the crash for me in emacs.

@vcunat

This comment has been minimized.

Copy link
Member

vcunat commented Jan 10, 2019

OK. Plan: I hope staging-next will be found good-enough to merge very soon, during the weekend at latest. Rebuild in progress: https://hydra.nixos.org/eval/1499603?compare=1499579

If that fails, I believe we can cherry-pick this to master directly.

@vcunat vcunat referenced this pull request Jan 12, 2019

Merged

Staging next #53483

0 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment