Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node packages.elm live #53739

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@tzemanovic
Copy link
Contributor

commented Jan 10, 2019

Motivation for this change

Added elm-live node package - live dev server for Elm.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tzemanovic added some commits Jan 10, 2019

@domenkozar

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

@GrahamcOfBorg build nodePackages.elm-live

@domenkozar

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

Could you rebase?

@Mic92

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

added in fb0d69d

@Mic92 Mic92 closed this Jan 17, 2019

@Mic92

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

also fa17085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.