Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages.nvidia_x11*: Add maintainer: baracoder #53743

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@baracoder
Copy link
Contributor

commented Jan 10, 2019

Motivation for this change

I bought some recent nvidia hardware, so I am stuck with it for a couple
of years and because of this, I have an interest in a working nvidia driver.

See also 9ee8cf5 and #50861 (comment)

/cc @vcunat @eadwu @Infinisil

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -570,6 +570,11 @@
github = "brendan-hall";
name = "Brendan Hall";
};
baracoder = {

This comment has been minimized.

Copy link
@Infinisil

Infinisil Jan 10, 2019

Member

If I remember correctly, a comes before h in the alphabet :)

This comment has been minimized.

Copy link
@baracoder

baracoder Jan 11, 2019

Author Contributor

🤦‍♂ amended

linuxPackages.nvidia_x11*: Add maintainer: baracoder
I bought some recent nVidia hardware, so I am stuck with it for a couple
of years and because of this, I have an interest in a working nVidia driver.

@baracoder baracoder force-pushed the baracoder:add-nvidia-maintainer branch from d70567f to ca1f092 Jan 11, 2019

@baracoder baracoder changed the title linuxPackages.nvidia_x11*: Add me as a maintainer linuxPackages.nvidia_x11*: Add maintainer: baracoder Jan 11, 2019

@Infinisil Infinisil merged commit 084e008 into NixOS:master Jan 11, 2019

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.