Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages.nvidia_x11*: Add maintainer: baracoder #53743

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

baracoder
Copy link
Contributor

Motivation for this change

I bought some recent nvidia hardware, so I am stuck with it for a couple
of years and because of this, I have an interest in a working nvidia driver.

See also 9ee8cf5 and #50861 (comment)

/cc @vcunat @eadwu @infinisil

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -570,6 +570,11 @@
github = "brendan-hall";
name = "Brendan Hall";
};
baracoder = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, a comes before h in the alphabet :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ amended

I bought some recent nVidia hardware, so I am stuck with it for a couple
of years and because of this, I have an interest in a working nVidia driver.
@baracoder baracoder changed the title linuxPackages.nvidia_x11*: Add me as a maintainer linuxPackages.nvidia_x11*: Add maintainer: baracoder Jan 11, 2019
@infinisil infinisil merged commit 084e008 into NixOS:master Jan 11, 2019
@baracoder baracoder deleted the add-nvidia-maintainer branch November 11, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants