Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc-arm-embedded: 7-2018-q2-update -> 8-2018-q4-major #53744

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@prusnak
Copy link
Contributor

commented Jan 10, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

Related: it might be a good idea to remove all older versions (right now we keep 4.x, 5, 6 and 7) and keep just the latest one (8). I'll amend the commit if @vinymeuh and @rasendubi agree.

@rasendubi

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

@prusnak I am against this as gcc-arm-embedded versions are not really backward compatible and that manifests in much more ways in embedded projects. (i.e., many embedded projects do not compile or even crash with newer versions of gcc)

FWIW, that was previously discussed at #52146

@rasendubi

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

@GrahamcOfBorg build gcc-arm-embedded

@prusnak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2019

@rasendubi I am fine with keeping all old versions and that's how I did this patch in the first place.

Let's review this as it is then.

@Mic92 Mic92 merged commit f3cb8ce into NixOS:master Jan 11, 2019

12 of 13 checks passed

nix-build -A gcc-arm-embedded --argstr system x86_64-darwin Build Results
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A gcc-arm-embedded --argstr system aarch64-linux Build Results
Details
nix-build -A gcc-arm-embedded --argstr system x86_64-linux Build Results
Details

@prusnak prusnak deleted the prusnak:gcc-arm-embedded-8 branch Jan 11, 2019

@rasendubi

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

@prusnak sure. I didn't block the PR—just hadn't time to wait for the build to finish. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.