New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nexus: 3.12.1 -> 3.14.0-04 #53746

Merged
merged 2 commits into from Jan 10, 2019

Conversation

Projects
None yet
4 participants
@zaninime
Copy link
Contributor

zaninime commented Jan 10, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zaninime

This comment has been minimized.

Copy link
Contributor Author

zaninime commented Jan 10, 2019

@Ma27

This comment has been minimized.

Copy link
Member

Ma27 commented Jan 10, 2019

@GrahamcOfBorg build nexus
@GrahamcOfBorg test nexus

@aespinosa

This comment has been minimized.

Copy link
Contributor

aespinosa commented Jan 10, 2019

Lgtm

nixos/nexus: increase disk size of VM test to 8GB
Nexus increased their default minimum disk space requirement to 4GB:

```
com.orientechnologies.orient.core.exception.OLowDiskSpaceException: Error occurred while executing a
write operation to database 'OSystem' due to limited free space on the disk (1823 MB). The database
is now working in read-only mode. Please close the database (or stop OrientDB), make room on your hard
drive and then reopen the database. The minimal required space is 4096 MB. Required space is now
set to 4096MB (you can change it by setting parameter storage.diskCache.diskFreeSpaceLimit) .
server# [   72.560866] zqnav3mg7m6ixvdcacgj7p5ibijpibx5-unit-script-nexus-start[627]:   DB name="OSystem"
```

Including the rest on the VM 8GB should be the most suitable solution.
As the installer test also takes 8GB of disk size this should still be
in an acceptable range.
@Ma27

This comment has been minimized.

Copy link
Member

Ma27 commented Jan 10, 2019

The test fails locally as it's lacking disk space (it seems as they've increased the minimum diskspace to 4096MB). If I manage to fix that, I'll push a fix :)

@Ma27

Ma27 approved these changes Jan 10, 2019

@Ma27

This comment has been minimized.

Copy link
Member

Ma27 commented Jan 10, 2019

As ofborg evaluates successfully and the test passes again, let's merge this 👍

@Ma27 Ma27 merged commit 44a8029 into NixOS:master Jan 10, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Ma27

This comment has been minimized.

Copy link
Member

Ma27 commented Jan 10, 2019

@zaninime thanks!

@zaninime

This comment has been minimized.

Copy link
Contributor Author

zaninime commented Jan 10, 2019

👍 does it make sense that we backport this to 18.09?

@zaninime zaninime deleted the zaninime:patch-1 branch Jan 10, 2019

@Ma27

This comment has been minimized.

Copy link
Member

Ma27 commented Jan 10, 2019

Are there any important patches like security fixes in 3.14 or 3.13? Unless I'm not sure if we want to backport the change, but feel free to open a PR with the patches against release-18.09 and discuss this with some more maintainers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment