Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: Adds patch for fixing wifi on raspberry pi #53747

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
4 participants
@bkchr
Copy link
Contributor

commented Jan 10, 2019

Motivation for this change

@kwohlfahrt here we go :)

Ping @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bkchr

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

Okay, don't merge. Needs some resolving!

@bkchr bkchr force-pushed the bkchr:raspberry_pi_wifi_fix_backport branch from 9fc6698 to 43f4fb3 Jan 10, 2019

@bkchr

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

Okay fixed, I needed to adapt the patch to work with 4.19.

@Mic92 Mic92 merged commit 4d22e46 into NixOS:release-18.09 Jan 10, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@bkchr bkchr deleted the bkchr:raspberry_pi_wifi_fix_backport branch Jan 10, 2019

@Synthetica9

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

@bkchr A bit late, but where does this patch come from?

@Mic92

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

see #53694 (comment) for source

@Synthetica9

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

Why not use fetchPatch in that case?

@Mic92

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

The patch had to be changed slightly while backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.