New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purescript: fix build compiling with ghc 8.4.4 #53748

Open
wants to merge 5 commits into
base: master
from

Conversation

@jacereda
Copy link
Contributor

jacereda commented Jan 10, 2019

Closes #53597.

Motivation for this change
Things done

Not sure this is the right thing though...

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endgame

This comment has been minimized.

Copy link
Contributor

endgame commented Jan 14, 2019

I don't use purescript, but I'd really like to see that aeson fix get merged. Hopefully it happens soon.

@domenkozar

This comment has been minimized.

Copy link
Member

domenkozar commented Jan 14, 2019

@GrahamcOfBorg build purescript

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Feb 13, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/nixos-19-03-feature-freeze/1950/23

@jacereda jacereda force-pushed the jacereda:fix-purescript-build branch from 9b902a9 to 0fbc185 Feb 17, 2019

@jacereda

This comment has been minimized.

Copy link
Contributor Author

jacereda commented Feb 17, 2019

Sorry about the mess.
I rebased to current master because a fix for aeson already landed in master.

@FRidh FRidh removed their request for review Feb 17, 2019

@FRidh FRidh removed request for nbp , rycee , thoughtpolice , ttuegel and zimbatm Feb 17, 2019

@ryantm

This comment has been minimized.

Copy link
Member

ryantm commented Feb 17, 2019

Hi, @jacereda.

Thanks for the contribution. Can you update the comments to include references to upstream tickets/issues for these issues?

Thanks,
Ryan

@jacereda

This comment has been minimized.

Copy link
Contributor Author

jacereda commented Feb 17, 2019

I'm trying to verify if cereal/psqueues are still a problem but I'm getting the build failure below. I found a similar problem here: #50920 (comment)

building [html]: targets for 4 source files that are out of date
updating environment: 4 added, 0 changed, 0 removed
reading sources... [ 25%] index
reading sources... [ 50%] intro
reading sources... [ 75%] invoking

Extension error:
The 'ghc-flag' directive is already registered to domain std
reading sources... [100%] markup
clang-5.0: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]
make[1]: *** [docs/users_guide/ghc.mk:16: docs/users_guide/build-html/users_guide/index.html] Error 2
make[1]: *** Waiting for unfinished jobs....
clang-5.0: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]

Extension error:
The 'ghc-flag' directive is already registered to domain std

looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [ 25%] index
make[1]: *** [docs/users_guide/ghc.mk:28: docs/users_guide/build-man/ghc.1] Error 2
writing output... [ 50%] intro
writing output... [ 75%] invoking
clang-5.0: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]
<<ghc: 20003168 bytes, 11 GCs, 233684/298496 avg/max bytes residency (2 samples), 24M in use, 0.000 INIT (0.004 elapsed), 0.021 MUT (0.876 elapsed), 0.019 GC (0.028 elapsed) :ghc>>
writing output... [100%] markup

/private/tmp/501/nix-build-ghc-8.4.4.drv-0/ghc-8.4.4/utils/haddock/doc/invoking.rst:457: WARNING: unknown option: -cpp
generating indices... genindex
writing additional pages... search
copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded, 1 warning.

The HTML pages are in .build-html.
cp -R utils/haddock/doc/.build-html utils/haddock/doc/haddock
make: *** [Makefile:127: all] Error 2
builder for '/nix/store/h7zflbah2x7n9zqcpfif3x3wzb12hqj2-ghc-8.4.4.drv' failed with exit code 2
cannot build derivation '/nix/store/fd4jy5xjyjaj02wv3y8g8bwvabbhd95k-purescript-0.12.2.drv': 1 dependencies couldn't be built

@jacereda

This comment has been minimized.

Copy link
Contributor Author

jacereda commented Feb 18, 2019

A sequential build failed as well. Still waiting for the job to finish, but I suspect it's due to the latest sphinx update.

cat utils/runghc/runghc.wrapper                                     >> inplace/bin/runghc
chmod +x                                                     inplace/bin/runghc
/nix/store/7p3m7ahh8p5wib5s8f1hfl7jxixqra2w-python3.7-sphinx-1.8.3/bin/sphinx-build -b html -d docs/users_guide/.doctrees-html -D latex_paper_size=letter docs/users_guide docs/users_guide/build-html/users_guide
Running Sphinx v1.8.3

Extension error:
The 'ghc-flag' directive is already registered to domain std
make[1]: *** [docs/users_guide/ghc.mk:16: docs/users_guide/build-html/users_guide/index.html] Error 2
make: *** [Makefile:127: all] Error 2
builder for '/nix/store/h7zflbah2x7n9zqcpfif3x3wzb12hqj2-ghc-8.4.4.drv' failed with exit code 2
cannot build derivation '/nix/store/dhc7s25szby99slfgsf3jdr60zl9v2ka-purescript-0.12.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/dhc7s25szby99slfgsf3jdr60zl9v2ka-purescript-0.12.2.drv' failed
@marsam

This comment has been minimized.

Copy link
Contributor

marsam commented Feb 18, 2019

thanks for working on this. btw I think 102c624 fixes #55662

@domenkozar

This comment has been minimized.

Copy link
Member

domenkozar commented Feb 18, 2019

@GrahamcOfBorg build purescript

@jacereda jacereda force-pushed the jacereda:fix-purescript-build branch from 102c624 to 9de6150 Feb 18, 2019

@jacereda

This comment has been minimized.

Copy link
Contributor Author

jacereda commented Feb 18, 2019

OK, the fix was wrong, second attempt...

@jacereda

This comment has been minimized.

Copy link
Contributor Author

jacereda commented Feb 18, 2019

I think it should be ready now.

@domenkozar

This comment has been minimized.

Copy link
Member

domenkozar commented Feb 19, 2019

@GrahamcOfBorg build purescript

@jacereda

This comment has been minimized.

Copy link
Contributor Author

jacereda commented Feb 19, 2019

Was the problem just a timeout? How do you see the full logs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment