Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purescript: fix build compiling with ghc 8.4.4 #53748

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
8 participants
@jacereda
Copy link
Contributor

commented Jan 10, 2019

Closes #53597.

Motivation for this change
Things done

Not sure this is the right thing though...

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endgame

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2019

I don't use purescript, but I'd really like to see that aeson fix get merged. Hopefully it happens soon.

@domenkozar

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

@GrahamcOfBorg build purescript

@nixos-discourse

This comment has been minimized.

Copy link

commented Feb 13, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/nixos-19-03-feature-freeze/1950/23

@jacereda

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2019

Sorry about the mess.
I rebased to current master because a fix for aeson already landed in master.

@FRidh FRidh removed request for FRidh and Profpatsch Feb 17, 2019

@domenkozar

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

@GrahamcOfBorg build purescript

@jacereda

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

Was the problem just a timeout? How do you see the full logs?

@jacereda

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2019

Loos like @peti disabled the sphinx docs, should I rebase and reenable or leave it disabled?

@domenkozar

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

@GrahamcOfBorg build purescript

@@ -45,7 +45,6 @@ self: super: {
unordered-containers = dontCheck super.unordered-containers;

# Test suite does not compile.
cereal = dontCheck super.cereal;

This comment has been minimized.

Copy link
@peti

peti Feb 21, 2019

Member

This change is unrelated to purescript. It would be better to submit it in a separate PR, because this change is totally uncontroversial and it can be merged very quickly.

@@ -54,7 +53,6 @@ self: super: {
hpc-coveralls = doJailbreak super.hpc-coveralls; # https://github.com/guillaume-nargeot/hpc-coveralls/issues/82
http-api-data = doJailbreak super.http-api-data;
persistent-sqlite = dontCheck super.persistent-sqlite;
psqueues = dontCheck super.psqueues; # won't cope with QuickCheck 2.12.x

This comment has been minimized.

Copy link
@peti

peti Feb 21, 2019

Member

ditto

@@ -60,7 +60,6 @@ self: super: {
hpc-coveralls = doJailbreak super.hpc-coveralls; # https://github.com/guillaume-nargeot/hpc-coveralls/issues/82
http-api-data = doJailbreak super.http-api-data;
persistent-sqlite = dontCheck super.persistent-sqlite;
psqueues = dontCheck super.psqueues; # won't cope with QuickCheck 2.12.x

This comment has been minimized.

Copy link
@peti

peti Feb 21, 2019

Member

ditto

@@ -3,6 +3,18 @@
}:

let
# sphinx update to 1.8.x broke ghc versions < 8.6
sphinx_1_7_9 = buildPackages.python3Packages.sphinx.overridePythonAttrs (o:

This comment has been minimized.

Copy link
@peti

peti Feb 21, 2019

Member

Please add the old Sphinx version into python-packages.nix.

This comment has been minimized.

Copy link
@jacereda

jacereda Feb 21, 2019

Author Contributor

Done.

@peti

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

Loos like @peti disabled the sphinx docs, should I rebase and reenable or leave it disabled?

It's preferable to build the docs, obviously, so if your fix works properly then please re-base it. I have also added a couple of other comments in my review.

@jacereda

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

@jacereda jacereda force-pushed the jacereda:fix-purescript-build branch from 43dc79c to 4bd060e Feb 21, 2019

@peti peti changed the base branch from master to haskell-updates Feb 21, 2019

@peti

peti approved these changes Feb 21, 2019

@peti

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

Test builds will be running at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates ... I'll merge to master once these come back successfully.

@peti peti merged commit 62026b3 into NixOS:haskell-updates Feb 21, 2019

1 check was pending

grahamcofborg-eval Checking new out paths
Details
@peti

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

This PR broke all ghc-8.2.2 and 8.4.4 builds: https://hydra.nixos.org/eval/1506062. I have reverted it from haskell-updates.

@jacereda

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

Doh! Sorry, try again please.

@jacereda

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

This is the new PR: #56162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.