Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/borgbackup: use coercedTo instead of apply on paths #53756

Merged
merged 2 commits into from
Jan 10, 2019

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

We were trying to use multiple files adding paths to a borgbackup job, but this did not work, since the definition uses either and then uses apply to convert to a list.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

@GrahamcOfBorg build nixosTests.borgbackup

Co-Authored-By: yorickvP <yorickvanpelt@gmail.com>
@dotlambda dotlambda merged commit 4d68e82 into NixOS:master Jan 10, 2019
@dotlambda
Copy link
Member

Thanks! Next time, please ping the maintainer, i.e. me in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants