New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Numpy on PyPy #53771

Open
wants to merge 4 commits into
base: master
from

Conversation

@leo60228
Copy link
Contributor

leo60228 commented Jan 10, 2019

Motivation for this change

Numpy works on PyPy as of October 2017, but tests fail for one of its dependencies. I applied a patch from Gentoo, disabled tests on pytest for PyPy (due to an upstream bug), and disabled tests on Numpy for PyPy (since documentation claims that they fail and I'm too impatient to test).

Resolves #53752

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@domenkozar

This comment has been minimized.

Copy link
Member

domenkozar commented Jan 10, 2019

@GrahamcOfBorg build pypyPackages.numpy

@leo60228

This comment has been minimized.

Copy link
Contributor Author

leo60228 commented Jan 10, 2019

I've used fetchpatch and doCheck, currently building. My VPS only has 1GB of RAM, so this is pretty slow.

@domenkozar

This comment has been minimized.

@leo60228

This comment has been minimized.

Copy link
Contributor Author

leo60228 commented Jan 10, 2019

That's an upstream bug. Will fix.

@leo60228

This comment has been minimized.

Copy link
Contributor Author

leo60228 commented Jan 10, 2019

I've disabled the tests (which has been done on mock master, but not in a release yet).

@leo60228

This comment has been minimized.

Copy link
Contributor Author

leo60228 commented Jan 10, 2019

Also, is there a good way to get an armv7 PyPy in nixpkgs? PyPy has a very long compilation (>1 hour and 4GB of RAM), and I believe (though I may be wrong) that cross-compilation changes the hash. In my fork I've added a derivation based off the official binaries, but that seems like a hack. PyPy doesn't support aarch64.

@domenkozar

This comment has been minimized.

Copy link
Member

domenkozar commented Jan 10, 2019

Sadly there's no provider with armv7 that would be able to support our farm :) Not sure about platform support.

@leo60228 leo60228 force-pushed the leo60228:numpy-pypy branch from 883c3e7 to f9cff8a Jan 10, 2019

@leo60228

This comment has been minimized.

Copy link
Contributor Author

leo60228 commented Jan 10, 2019

I've fixed the issues so far.

@leo60228

This comment has been minimized.

Copy link
Contributor Author

leo60228 commented Jan 10, 2019

@GrahamcOfBorg build pypyPackages.numpy

1 similar comment
@domenkozar

This comment has been minimized.

Copy link
Member

domenkozar commented Jan 10, 2019

@GrahamcOfBorg build pypyPackages.numpy

@leo60228

This comment has been minimized.

Copy link
Contributor Author

leo60228 commented Jan 10, 2019

Hm. What's the error? I don't see one.

@FRidh
Copy link
Member

FRidh left a comment

This needs to target staging.

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Jan 13, 2019

Add a comment when disabling tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment