New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: 0.34.0 -> 0.34.0.1 (CVE-2019-5885) #53772

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
5 participants
@pacien
Copy link
Contributor

pacien commented Jan 10, 2019

Motivation for this change

Security update: https://matrix.org/blog/2019/01/10/critical-security-update-synapse-0-34-0-1-synapse-0-34-1-1/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien

This comment has been minimized.

Copy link
Contributor Author

pacien commented Jan 10, 2019

This security update should probably be back-ported to release-18.09 as well, but I'm not sure whether the dependencies are up-to-date on that branch.

@erictapen

This comment has been minimized.

Copy link
Contributor

erictapen commented Jan 10, 2019

@pacien Thanks! I just tested this on my private Matrix instance on nixos-18.09 and it doesn't look broken.

@pacien pacien referenced this pull request Jan 10, 2019

Closed

matrix-synapse: 0.34.0 -> 0.34.0.1 #53773

3 of 10 tasks complete
@pstn

This comment has been minimized.

Copy link
Contributor

pstn commented Jan 10, 2019

Can confirm that this patch indeed works on 18.09. I also tested it on my server.

@Ekleog

This comment has been minimized.

Copy link
Member

Ekleog commented Jan 10, 2019

Thanks! Merged in fc7bbfd, and backported in 76cebbc

@Ekleog Ekleog merged commit 0be693a into NixOS:master Jan 10, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment