New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl: 2019.01.02 -> 2019.01.10 #53774

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
3 participants
@bachp
Copy link
Contributor

bachp commented Jan 10, 2019

Motivation for this change

Update to latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 10, 2019

$ youtube-dl "https://media.ccc.de/v/35c3-9716-du_kannst_alles_hacken_du_darfst_dich_nur_nicht_erwischen_lassen"
Traceback (most recent call last):
  File "/nix/store/x76ipjbvdfrp1g6rid24c335mbnc31g2-python2.7-youtube-dl-2019.01.10/bin/.youtube-dl-wrapped", line 8, in <module>
    from youtube_dl import main
  File "/nix/store/r1jfcx31xrdy4yn5grrmbaqwqcwkskc5-python3.7-youtube-dl-2019.01.10/lib/python3.7/site-packages/youtube_dl/__init__.py", line 15, in <module>
    from .options import (
  File "/nix/store/r1jfcx31xrdy4yn5grrmbaqwqcwkskc5-python3.7-youtube-dl-2019.01.10/lib/python3.7/site-packages/youtube_dl/options.py", line 8, in <module>
    from .downloader.external import list_external_downloaders
  File "/nix/store/r1jfcx31xrdy4yn5grrmbaqwqcwkskc5-python3.7-youtube-dl-2019.01.10/lib/python3.7/site-packages/youtube_dl/downloader/__init__.py", line 5, in <module>
    from .hls import HlsFD
  File "/nix/store/r1jfcx31xrdy4yn5grrmbaqwqcwkskc5-python3.7-youtube-dl-2019.01.10/lib/python3.7/site-packages/youtube_dl/downloader/hls.py", line 6, in <module>
    from Crypto.Cipher import AES
  File "/nix/store/9b1db7pc3l1m2qxyr3g41s9x7kb6pnzc-python3.7-pycryptodome-3.7.0/lib/python3.7/site-packages/Crypto/Cipher/__init__.py", line 27, in <module>
    from Crypto.Cipher._mode_ecb import _create_ecb_cipher
  File "/nix/store/9b1db7pc3l1m2qxyr3g41s9x7kb6pnzc-python3.7-pycryptodome-3.7.0/lib/python3.7/site-packages/Crypto/Cipher/_mode_ecb.py", line 47, in <module>
    """
  File "/nix/store/9b1db7pc3l1m2qxyr3g41s9x7kb6pnzc-python3.7-pycryptodome-3.7.0/lib/python3.7/site-packages/Crypto/Util/_raw_api.py", line 289, in load_pycryptodome_raw_lib
    raise OSError("Cannot load native module '%s': %s" % (name, ", ".join(attempts)))
OSError: Cannot load native module 'Crypto.Cipher._raw_ecb': Trying '_raw_ecb.so': /nix/store/9b1db7pc3l1m2qxyr3g41s9x7kb6pnzc-python3.7-pycryptodome-3.7.0/lib/python3.7/site-packages/Crypto/Util/../Cipher/_raw_ecb.so: cannot open shared object file: No such file or directory, Trying '_raw_ecbmodule.so': /nix/store/9b1db7pc3l1m2qxyr3g41s9x7kb6pnzc-python3.7-pycryptodome-3.7.0/lib/python3.7/site-packages/Crypto/Util/../Cipher/_raw_ecbmodule.so: cannot open shared object file: No such file or directory

There seems to be some mixing up of Python 2.7 and 3.7.

EDIT: That seems to be me mixing the system version of youtube-dl with the new one. Wondering why that happens.

@bachp

This comment has been minimized.

Copy link
Contributor Author

bachp commented Jan 11, 2019

@dotlambda Is your observation on NixOS or another distribution?

I sucessfully tested this on my Arch Linux machine where I also have a version of youtube-dl installed via pacman.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 11, 2019

It's on NixOS. I am on nixos-unstable and have youtube-dl in my environment.systemPackages.

@dotlambda dotlambda merged commit 77ccb13 into NixOS:master Jan 13, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment