Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-music-scripts: init at 3.0.0 #53782

Merged
merged 11 commits into from Jan 20, 2019

Conversation

@jbaum98
Copy link
Contributor

commented Jan 10, 2019

Motivation for this change

Add google-music-scripts.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [] Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jbaum98 jbaum98 force-pushed the jbaum98:google-music-scripts branch 3 times, most recently from 4a18cfe to 920913c Jan 12, 2019

@jbaum98 jbaum98 force-pushed the jbaum98:google-music-scripts branch from 13d6d28 to 6bc8ca7 Jan 15, 2019

@jbaum98 jbaum98 changed the title google-music-scripts: init at 2.0.0 google-music-scripts: init at 3.0.0 Jan 15, 2019

@jbaum98

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2019

@worldofpeace Now that google-music-scripts has been updated to allow click version 7, I think this is ready to go.

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

@worldofpeace Now that google-music-scripts has been updated to allow click version 7, I think this is ready to go.

Nice, I'll give this a final review to see if there's anything amiss.

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

Looks like 6bc8ca7 had a little fixup mishap

@jbaum98

This comment has been minimized.

Copy link
Contributor Author

commented Jan 18, 2019

So if a package has no tests we want to explicitly disable checkPhase?

@jbaum98 jbaum98 force-pushed the jbaum98:google-music-scripts branch from 6bc8ca7 to 0cae3d9 Jan 18, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

So if a package has no tests we want to explicitly disable checkPhase?

Yep. Other python maintainers here also agree on this.

@worldofpeace
Copy link
Member

left a comment

Think it's good 👍
Thanks for your patience @jbaum98

Haven't tested the actual function of the program though.

I'll merge this with the approval of one more maintainer and If someone can vouch for the function.

cc @dotlambda

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

Note, if I don't get another approval within <24hrs I'll just merge it.

Show resolved Hide resolved pkgs/development/python-modules/audio-metadata/default.nix Outdated
};

# hypothesis-pytest is not needed
patches = [ ./hypothesis_pytest.patch ];

This comment has been minimized.

Copy link
@dotlambda

dotlambda Jan 18, 2019

Member

I'd prefer doing this in postPatch using substituteInPlace.
Did you submit a patch upstream?

This comment has been minimized.

Copy link
@jbaum98

jbaum98 Jan 18, 2019

Author Contributor

I opened a PR, but I actually realized that it's building without the patch.

Show resolved Hide resolved pkgs/development/python-modules/google-music-proto/default.nix Outdated
Show resolved Hide resolved pkgs/development/python-modules/google-music-utils/default.nix Outdated
Show resolved Hide resolved pkgs/development/python-modules/google-music-utils/default.nix
Show resolved Hide resolved pkgs/development/python-modules/google-music/default.nix Outdated
Show resolved Hide resolved pkgs/development/python-modules/pprintpp/default.nix Outdated
@dotlambda

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

I can confirm that google-music-scripts is functioning correctly.

@jbaum98 jbaum98 force-pushed the jbaum98:google-music-scripts branch from c74286c to 781f8e1 Jan 18, 2019

@jbaum98 jbaum98 force-pushed the jbaum98:google-music-scripts branch from 781f8e1 to 9237f2b Jan 18, 2019

@dotlambda
Copy link
Member

left a comment

Remove the patch files.

Show resolved Hide resolved pkgs/development/python-modules/pprintpp/default.nix Outdated

@jbaum98 jbaum98 force-pushed the jbaum98:google-music-scripts branch from 9237f2b to dff4cc6 Jan 18, 2019

@jbaum98 jbaum98 force-pushed the jbaum98:google-music-scripts branch from dff4cc6 to bc820fa Jan 18, 2019

@worldofpeace worldofpeace merged commit 7e24c25 into NixOS:master Jan 20, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jan 20, 2019

Maybe a little more than 24 hours 🤣

@jbaum98

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2019

No problem, thanks @worldofpeace and @dotlambda for your help!

@jbaum98 jbaum98 deleted the jbaum98:google-music-scripts branch Jan 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.