New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.HaTeX: jailbreak #53790

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
3 participants
@romildo
Copy link
Contributor

romildo commented Jan 11, 2019

Motivation for this change

Broken by recent haskell updates.

See Daniel-Diaz/HaTeX#126.

Depends on #53789.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@peti
Copy link
Member

peti left a comment

Please add that jailbreak to the ghc 6.8.x specific configure file, not into common. Other compilers don't need it.

@romildo romildo force-pushed the romildo:fix.HaTeX branch from 4e47b21 to 9536ada Jan 12, 2019

@romildo

This comment has been minimized.

Copy link
Contributor

romildo commented Jan 12, 2019

Please add that jailbreak to the ghc 6.8.x specific configure file, not into common. Other compilers don't need it.

Done.

@peti peti merged commit b661d8d into NixOS:master Jan 13, 2019

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@romildo romildo deleted the romildo:fix.HaTeX branch Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment