Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ninja: re2c is not for building docs #53793

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
5 participants
@volth
Copy link
Contributor

commented Jan 11, 2019

Motivation for this change

re2c is used not for build docs, but for the main executable

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

This should go to staging.

@volth volth force-pushed the volth:patch-297 branch from 78f5287 to c1d8284 Jan 11, 2019

@volth volth changed the base branch from master to staging Jan 11, 2019

@volth

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2019

Oh, I did not expect mass-rebuild because buildDocs is usually true, the patch supposed to change nothing.
Rebased

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

It's true that this isn't for building docs, but it I think it's still optional.

So maybe just change the commit msg to ninja: re2c is not for building docs?

@volth

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2019

Yes, ninja sources include re2c's output files, so unless we change the sources by applying a patch, re2c is not even launched

ninja: re2c is not for building docs
ninja sources include re2c's output files, so unless we change the sources by applying a patch, re2c is not even launched
anyway, it is not relevant to building docs
@hedning

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

Oh, I did not expect mass-rebuild because buildDocs is usually true, the patch supposed to change nothing.

Unfortunately buildInputs et. al. is sensitive to the order of inputs for some reason.

@FRidh FRidh changed the title ninja: re2c is not an optional dependency ninja: re2c is not for building docs Jan 13, 2019

@FRidh FRidh merged commit a4faf59 into NixOS:staging Jan 13, 2019

12 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A ninja --argstr system aarch64-linux Build Results
Details
nix-build -A ninja --argstr system x86_64-linux Build Results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.