New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some reasonable defaults to LIRC's module #53795

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@BadDecisionsAlex
Copy link

BadDecisionsAlex commented Jan 11, 2019

Motivation for this change

After spending a few hours trying to install LIRC I realized that many of my issues were from a lack of default settings that could get the program up and running. This will allow many users to let LIRC run out of the box.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa

This comment has been minimized.

Copy link
Member

markuskowa commented Jan 11, 2019

CC @ck3d

[lircmd]
uinput = False
nodaemon = False

This comment has been minimized.

@Mic92

Mic92 Jan 11, 2019

Contributor

To bad this was not added in the first place. I would prefer having sane default options, that can be extended by extraOptions. Do you think users would need to extend the default options in the common case?

@ck3d

This comment has been minimized.

Copy link
Contributor

ck3d commented Jan 12, 2019

My configuration file looks as follows:

[lircd]
driver = ftdi
device = product=0x6015

I set none of the fault values in my configuration file without any problems. Could you please specify which problems you have?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment