-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Added some reasonable defaults to LIRC's module #53795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CC @ck3d |
|
||
[lircmd] | ||
uinput = False | ||
nodaemon = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To bad this was not added in the first place. I would prefer having sane default options, that can be extended by extraOptions
. Do you think users would need to extend the default options in the common case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now this is alright, can always add that later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed.
My configuration file looks as follows:
I set none of the default values in my configuration file without any problems. Could you please specify which problems you have? |
@BadDecisionsAlex We should strive to keep the default config as small as possible. If @ck3d's config works then that is preferred. |
Sorry for the late reply, I've been swamped. |
No problem.
In my case, everything is found. The default, ftdi and 30 more drivers. I think the main reason is the missing device setting. Please give following config a try:
or set it as extraArguments: I had a look into lirc sources and it showed that the default device of the lircd default driver is /dev/lirc/0 (defined as LIRC_DRIVER_DEVICE). If /dev/lirc0 is a better default, we should think about patching lirc. As alternative we could provide two NixOS options for driver and device. |
Fixed revisions: 1) Uses `pname`. 2) URL uses version variable in path. Data type for `url` was changed from path to string.
The last commit mistakenly reverted the URL to "old" again. The change has been re-applied.
Sorry I did not mean to revive this. This has been sitting without interest for a while. I'm closing it. |
Motivation for this change
After spending a few hours trying to install LIRC I realized that many of my issues were from a lack of default settings that could get the program up and running. This will allow many users to let LIRC run out of the box.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)