matrix-synapse: 0.34.0.1 -> 0.34.1.1

[nyanloutre]

Motivation for this change

Need a pysaml2 update, I am working on it done

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

[Ekleog]

This change appears to break the matrix-synapse NixOS test (nix-build nixos/tests/matrix-synapse.nix): ERROR:root:Needed pysaml2>=4.5.0 but it was not installed

[nyanloutre]

@Ekleog it seems the pysaml2 package did have significant changes since last version, but the matrix test is passing and it's working for me

[dotlambda]

Please try enabling them again.

[nyanloutre]

The tests are not included in the Pypi archive, but are available in the GitHub archive

If I enable them I get this error immediately:

json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

More logs: https://gist.github.com/nyanloutre/e6d01b47d68ea3d5f2e1e41086184303

[nyanloutre]

It was because the setup.py test command was wrong and had to specify it.

I now get ======== 3 failed, 669 passed, 2 skipped, 37 warnings in 216.40 seconds ========

The failing tests are trying to access an external resource

[dotlambda]

The switch to Python 3 should have been made in 35efbed.
Can you please try whether it's possible to switch now?

[nyanloutre]

@dotlambda is it only needed to switch the python2 argument to python3 ?

If so I get a failing test:

test.test_support.TestSupport.test_get_original_stdout
===============================================================================
[FAIL]
Traceback (most recent call last):
  File "/nix/store/5di2wpc5h7faqidsikgb94rwdbwy2y3l-python3-3.7.2/lib/python3.7/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/nix/store/5di2wpc5h7faqidsikgb94rwdbwy2y3l-python3-3.7.2/lib/python3.7/unittest/case.py", line 615, in run
    testMethod()
  File "/nix/store/5di2wpc5h7faqidsikgb94rwdbwy2y3l-python3-3.7.2/lib/python3.7/test/test_support.py", line 410, in test_check__all__
    blacklist=blacklist)
  File "/nix/store/5di2wpc5h7faqidsikgb94rwdbwy2y3l-python3-3.7.2/lib/python3.7/test/support/__init__.py", line 2556, in check__all__
    test_case.assertCountEqual(module.__all__, expected)
  File "/nix/store/5di2wpc5h7faqidsikgb94rwdbwy2y3l-python3-3.7.2/lib/python3.7/unittest/case.py", line 1200, in assertCountEqual
    self.fail(msg)
  File "/nix/store/5di2wpc5h7faqidsikgb94rwdbwy2y3l-python3-3.7.2/lib/python3.7/unittest/case.py", line 680, in fail
    raise self.failureException(msg)
builtins.AssertionError: Element counts were not equal:
First has 1, Second has 0:  'SkipTest'

[dotlambda]

The dependency on matrix-angular-sdk seems to have been removed in matrix-org/synapse@df96177#diff-330f0c9df17ab9196f1537b1d625b6bb.

[dotlambda]

@nyanloutre Actually, matrix-angular-sdk should also be removed from the let statement.
Also, we should fine some meaningful way to squash the commits into a few less.

[dotlambda]

Someone should try this on a real-world home server with the Python 3 switch applied.

[nyanloutre]

Thanks for the help @dotlambda

I am installing this on my server right now

[dotlambda]

@nyanloutre Did it work?

[dotlambda]

@GrahamcOfBorg build matrix-synapse nixosTests.matrix-synapse

[nyanloutre]

@dotlambda yes, it's been 2 days and it's still working well