Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scid-vs-pc: 4.18.1 -> 4.19 #53800

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
3 participants
@jfrankenau
Copy link
Contributor

commented Jan 11, 2019

Motivation for this change

Update and create desktop entry file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @paraseba

Show resolved Hide resolved pkgs/games/scid-vs-pc/default.nix Outdated
Show resolved Hide resolved pkgs/games/scid-vs-pc/default.nix Outdated
Show resolved Hide resolved pkgs/games/scid-vs-pc/default.nix Outdated
@veprbl

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

@jfrankenau jfrankenau force-pushed the jfrankenau:update-scid branch from d968032 to b7f7b5e Feb 7, 2019

@jfrankenau

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2019

@veprbl, thank you for your review. I’ve pushed the appropriate changes.

@veprbl

veprbl approved these changes Feb 7, 2019

Copy link
Member

left a comment

Thank you!

@veprbl veprbl merged commit 5704496 into NixOS:master Feb 7, 2019

12 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
scid-vs-pc on aarch64-linux Success
Details
scid-vs-pc on x86_64-linux Success
Details

@jfrankenau jfrankenau deleted the jfrankenau:update-scid branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.