-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
nixos-rebuild: allow to override builders #53801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
root) to be configured as trusted user in nix daemon. This can be | ||
achived by using the <literal>nix.trustedUsers</literal> nixos option. | ||
Examples values for that option are described in the | ||
<literal>Remote builds chapter<literal> in the Nix manual, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grahamc can you help me out with converting this to a cross-reference here?
Allow to specify remote builders ad-hoc for building the new system. | ||
This requires user executing <command>nixos-rebuild</command> (usually | ||
root) to be configured as trusted user in nix daemon. This can be | ||
achived by using the <literal>nix.trustedUsers</literal> nixos option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixos options probably also have a special markup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as trusted user in nix daemon
-> as a trusted user in the Nix daemon
.
nixos option
-> NixOS option
.
j="$1"; shift 1 | ||
extraBuildFlags+=("$i" "$j") | ||
;; | ||
--show-trace|--no-build-hook|--keep-failed|-K|--keep-going|-k|--verbose|-v|-vv|-vvv|-vvvv|-vvvvv|--fallback|--repair|--no-build-output|-Q|-j*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--no-build-hook
is no longer accepted since nix 2.0.
There was also an issue related to that. @vcuncat do you remember which one this was? |
<listitem> | ||
<para> | ||
Allow to specify remote builders ad-hoc for building the new system. | ||
This requires user executing <command>nixos-rebuild</command> (usually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user
-> the user
.
Since nix 2.0 the no-build-hook option was replaced by the builders options that allows to override remote builders ad-hoc. Since it is useful to disable remote builders updating nixos without network, this commit reintroduces the option.
Co-Authored-By: Mic92 <Mic92@users.noreply.github.com>
Co-Authored-By: Mic92 <Mic92@users.noreply.github.com>
|
Ah indeed, that explains my confusion. |
@dtzWill yes, plus some documentation, which does not hurt, especially that root is not in the trusted user group by default. |
Yes indeed, thank you! \o/ |
This merge broke the build of NixOS manual: https://hydra.nixos.org/build/87335696 |
Ah, just a trivial typo. I fixed it. |
Since nix 2.0 the no-build-hook option was replaced by the builders options
that allows to override remote builders ad-hoc.
Since it is useful to disable remote builders updating nixos without network,
this commit reintroduces the option.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)