Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

folly: 2018.10.29.00 -> 2019.01.07.00 #53812

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@siddharthist
Copy link
Contributor

commented Jan 11, 2019

Motivation for this change

This is necessary to build recent versions of Fizz, which I have a Nix build for and am ready to submit when this is merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siddharthist

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2019

Note that this commit also removes the libiberty dependency. Despite the fact that this is listed in the README, it doesn't appear to be necessary to build even the static libraries.

@siddharthist

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

Closing due to 4f621ca

@siddharthist siddharthist deleted the siddharthist:folly branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.