update most packages I maintain #53818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
8.has: clean-up
10.rebuild-darwin: 0
veprbl
added
the
11.by: package-maintainer
|
openmpt123 still fails to build: https://gist.github.com/Mic92/0345c5294f04134388177780648e16d5 |
|
@Mic92 do we have issues with static libraries in NixOS? I see |
|
@gnidorah we don't build static libraries usually like most linux distributions, but they should work. There is a static overlay called pkgsStatic that enables static linking by default in some packages. |
FRidh
reviewed
Jan 13, 2019
| doCheck = true; | ||
|
|
||
| buildInputs = [ pkgconfig ]; | ||
| nativeBuildInputs = [ zlib mpg123 libogg libvorbis portaudio libsndfile flac ]; |
There was a problem hiding this comment.
buildInputs and nativeBuildInputs are the other way around
FRidh
reviewed
Jan 13, 2019
| installFlags = "PREFIX=\${out}"; | ||
| buildInputs = [ zlib mpg123 libogg libvorbis portaudio libsndfile flac ]; | ||
|
|
||
| configureFlags = [ |
There was a problem hiding this comment.
Note we often adjust this flag using usePulseAudio = config.pulseaudio or stdenv.isLinux;
|
Merge please? |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
nix-build -A openmpt123 -A vkquake -A franz -A openmw-tes3mp -A kmsxx -A openjk -A mytetra -A qdirstat -A python27Packages.kmsxx -A python37Packages.kmsxx -A ps_mem -A vk-messenger
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)