Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_rpi: allow modDirVersion override #53821

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@eadwu
Copy link
Contributor

commented Jan 12, 2019

Motivation for this change

I like having a consistent kernel version while overrideDerivation doesn't seem to override modDirVersion.

4.19.14 boots on raspberry pi 3 b+.

    kernelPackages = pkgs.linuxPackagesFor (pkgs.linux_rpi.override {
      argsOverride = rec {
        version = "${modDirVersion}-20190109";
        modDirVersion = "4.19.14";

        src = pkgs.fetchFromGitHub {
          owner = "raspberrypi";
          repo = "linux";
          rev = "7e312d57b01683ee93699fdac1121d5cc62fb211";
          sha256 = "0wci548pwkcjd7zjm17m3d8lcvk0m5x8p90sd516mpl06ghyf9iy";
        };
      };
    });
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aneeshusa

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2019

Can you try using overrideAttrs instead, which IIRC should handle this out of the box? Docs: https://nixos.org/nixpkgs/manual/#sec-pkg-overrideAttrs

@eadwu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2019

overrideAttrs results in an error being produced in the configuration, namely attribute 'overrideAttrs' missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.