New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] pythonPackages.httpretty: disable tests on aarch64 #53822

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@eadwu
Copy link
Contributor

eadwu commented Jan 12, 2019

Motivation for this change

Needed to complete compilation for nixops on raspberry pi 3 b+.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 12, 2019

Please disable the specific test instead.

@eadwu eadwu force-pushed the eadwu:pythonPackages.httpretty/disable-tests-aarch64 branch 3 times, most recently from 2d48633 to 542f99a Jan 12, 2019

@eadwu eadwu force-pushed the eadwu:pythonPackages.httpretty/disable-tests-aarch64 branch from 542f99a to 2ab05df Jan 12, 2019

@eadwu

This comment has been minimized.

Copy link
Contributor

eadwu commented Jan 12, 2019

Can't figure out how to skip the test, looking at other patches @skip or @unittest.skip is what I want, but none are working.

@eadwu eadwu changed the title pythonPackages.httpretty: disable tests on aarch64 [WIP] pythonPackages.httpretty: disable tests on aarch64 Jan 12, 2019

@eadwu eadwu force-pushed the eadwu:pythonPackages.httpretty/disable-tests-aarch64 branch 2 times, most recently from 560dce3 to 4183e00 Jan 12, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 13, 2019

@GrahamcOfBorg build python2.pkgs.httpretty python3.pkgs.httpretty

@eadwu eadwu force-pushed the eadwu:pythonPackages.httpretty/disable-tests-aarch64 branch from 4183e00 to c06ef2d Jan 13, 2019

@eadwu eadwu changed the title [WIP] pythonPackages.httpretty: disable tests on aarch64 pythonPackages.httpretty: disable tests on aarch64 Jan 13, 2019

@eadwu eadwu changed the title pythonPackages.httpretty: disable tests on aarch64 [WIP] pythonPackages.httpretty: disable tests on aarch64 Jan 13, 2019

@eadwu

This comment has been minimized.

Copy link
Contributor

eadwu commented Jan 16, 2019

Still trying to build pythonPackages.httpretty on my raspberry pi ... I'll change the title when I can verify it.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 16, 2019

Btw, did you open an upstream issue about this?

@eadwu

This comment has been minimized.

Copy link
Contributor

eadwu commented Jan 16, 2019

So far, I'm not even close to reproducing the error, failing on dependency gfortran, so that'll have to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment