Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.httpretty: disable broken test on aarch64 #53822

Conversation

Projects
None yet
3 participants
@eadwu
Copy link
Contributor

commented Jan 12, 2019

Motivation for this change

Needed to complete compilation for nixops on raspberry pi 3 b+.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

Please disable the specific test instead.

@eadwu eadwu force-pushed the eadwu:pythonPackages.httpretty/disable-tests-aarch64 branch 3 times, most recently from 2d48633 to 542f99a Jan 12, 2019

@eadwu eadwu force-pushed the eadwu:pythonPackages.httpretty/disable-tests-aarch64 branch from 542f99a to 2ab05df Jan 12, 2019

@eadwu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2019

Can't figure out how to skip the test, looking at other patches @skip or @unittest.skip is what I want, but none are working.

@eadwu eadwu changed the title pythonPackages.httpretty: disable tests on aarch64 [WIP] pythonPackages.httpretty: disable tests on aarch64 Jan 12, 2019

@eadwu eadwu force-pushed the eadwu:pythonPackages.httpretty/disable-tests-aarch64 branch 2 times, most recently from 560dce3 to 4183e00 Jan 12, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

commented Jan 13, 2019

@GrahamcOfBorg build python2.pkgs.httpretty python3.pkgs.httpretty

@eadwu eadwu force-pushed the eadwu:pythonPackages.httpretty/disable-tests-aarch64 branch from 4183e00 to c06ef2d Jan 13, 2019

@eadwu eadwu changed the title [WIP] pythonPackages.httpretty: disable tests on aarch64 pythonPackages.httpretty: disable tests on aarch64 Jan 13, 2019

@eadwu eadwu changed the title pythonPackages.httpretty: disable tests on aarch64 [WIP] pythonPackages.httpretty: disable tests on aarch64 Jan 13, 2019

@eadwu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

Still trying to build pythonPackages.httpretty on my raspberry pi ... I'll change the title when I can verify it.

@dotlambda

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

Btw, did you open an upstream issue about this?

@eadwu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

So far, I'm not even close to reproducing the error, failing on dependency gfortran, so that'll have to wait.

@eadwu

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

Looks like this should fix the build, looking at the hydra build log [1]. I'll build it on my Pi by tomorrow if not tonight to see if it actually does. Created upstream issue [2] though it's been 3 months since the last commit so not really expecting anything.

Builds fine on my rpi3b+.

[1] https://hydra.nixos.org/build/89035814/nixlog/1
[2] gabrielfalcao/HTTPretty#374

@eadwu eadwu force-pushed the eadwu:pythonPackages.httpretty/disable-tests-aarch64 branch from c06ef2d to 2c900c5 Feb 18, 2019

@eadwu eadwu changed the title [WIP] pythonPackages.httpretty: disable tests on aarch64 pythonPackages.httpretty: disable tests on aarch64 Feb 18, 2019

@eadwu eadwu changed the title pythonPackages.httpretty: disable tests on aarch64 pythonPackages.httpretty: disable broken test on aarch64 Mar 10, 2019

@eadwu

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2019

Doesn't look like it's needed anymore since it seems like it succeeds now? Even though the error has popped up 1 time in the last 5 builds.

@eadwu eadwu closed this May 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.