Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: 1.30.1 -> 1.30.2 #53823

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
None yet
4 participants
@eadwu
Copy link
Contributor

commented Jan 12, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

@GrahamcOfBorg build vscode vscode-with-extensions

@veprbl

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

@GrahamcOfBorg build vscode.src

@veprbl

veprbl approved these changes Jan 12, 2019

Copy link
Member

left a comment

Builds on macOS

@worldofpeace
Copy link
Member

left a comment

Still executes on NixOS for me 👍

@worldofpeace worldofpeace merged commit df712e2 into NixOS:master Jan 12, 2019

12 of 16 checks passed

nix-build -A vscode -A vscode-with-extensions --argstr system aarch64-linux Build Results
Details
nix-build -A vscode -A vscode-with-extensions --argstr system x86_64-darwin Build Results
Details
nix-build -A vscode -A vscode-with-extensions --argstr system x86_64-linux Build Results
Details
nix-build -A vscode.src --argstr system aarch64-linux Build Results
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A vscode.src --argstr system x86_64-darwin Build Results
Details
nix-build -A vscode.src --argstr system x86_64-linux Build Results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.