pythonPackages.pyment: init at 0.3.3 #53830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jethrokuan
commented
Jan 12, 2019
GrahamcOfBorg
added
6.topic: python
8.has: package (new)
dotlambda
requested changes
Jan 12, 2019
| meta = with lib; { | ||
| homepage = https://github.com/dadadel/pyment; | ||
| description = "Create, update or convert docstrings in existing Python files, managing several styles."; | ||
| platforms = platforms.all; |
|
|
||
| meta = with lib; { | ||
| homepage = https://github.com/dadadel/pyment; | ||
| description = "Create, update or convert docstrings in existing Python files, managing several styles."; |
There was a problem hiding this comment.
dotlambda
previously requested changes
Jan 12, 2019
| { stdenv, lib, buildPythonPackage, fetchPypi }: | ||
|
|
||
| buildPythonPackage rec { | ||
| pname = "Pyment"; |
There was a problem hiding this comment.
Suggested change
| pname = "Pyment"; | |
| pname = "pyment"; |
| version = "0.3.3"; | ||
|
|
||
| src = fetchPypi { | ||
| inherit pname version; |
There was a problem hiding this comment.
Suggested change
| inherit pname version; | |
| pname = "Pyment"; | |
| inherit version; |
|
Please squash the commits into a single one with a message exactly as this PR's title. |
jethrokuan
force-pushed
the
pkg-init/pyment
branch
from
17329da to
b57527b
Compare
|
done! |
|
@GrahamcOfBorg build python2.pkgs.pyment python3.pkgs.pyment |
worldofpeace
approved these changes
Jan 13, 2019
jethrokuan
force-pushed
the
pkg-init/pyment
branch
from
b57527b to
94de11a
Compare
|
resolved all outstanding comments |
|
@GrahamcOfBorg build python2.pkgs.pyment python3.pkgs.pyment |
|
@jethrokuan To issue ofborg commands such as i.e your github handle somewhere here@GrahamcOfBorg build python2.pkgs.pyment python3.pkgs.pyment |
I see haha. |
|
Thanks for your contribution @jethrokuan ❇️ |
|
Thanks @worldofpeace and @dotlambda for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
init new package pyment.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)