Skip to content

/nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xsuspender: init at 1.1 #53850

Merged
merged 1 commit into from Feb 7, 2019
+38 −0

Conversation

Reviewers

@kernc kernc

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 8.has: package (new)
Projects
None yet
Milestone
No milestone
3 participants
@offlinehacker @kernc @GrahamcOfBorg
@offlinehacker
Copy link
Contributor

commented Jan 12, 2019 •
edited

Motivation for this change

This PR packages xsuspender app, that suspends X applications whether they are focused or not.

More info about this awesome tool: https://kernc.github.io/xsuspender/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@offlinehacker offlinehacker added the 8.has: package (new) label Jan 12, 2019

@offlinehacker offlinehacker force-pushed the xtruder:pkgs/xsuspender/init branch from 736725f to 7414617 Jan 12, 2019

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jan 12, 2019

@kernc

kernc reviewed Jan 20, 2019
View changes

Show resolved Hide resolved pkgs/applications/misc/xsuspender/default.nix

@offlinehacker offlinehacker force-pushed the xtruder:pkgs/xsuspender/init branch 2 times, most recently from ed1a5a7 to 859c4f4 Jan 20, 2019

@offlinehacker offlinehacker changed the title xsuspender: init at 1.0 xsuspender: init at 1.1 Jan 20, 2019

@offlinehacker

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 20, 2019

In a meantime i updated to 1.1, which removes bash and coreutils from additional dependencies and now it only requires procps, which is awesome, good work @kernc
@offlinehacker
xsuspender: init at 1.1
Unverified
The key that signed this is expired.
GPG key ID: 916062A1C4748647 Learn about signing commits
Loading status checks…
a97966a

@offlinehacker offlinehacker force-pushed the xtruder:pkgs/xsuspender/init branch from 859c4f4 to a97966a Jan 20, 2019

@kernc

kernc approved these changes Jan 20, 2019
View changes

@offlinehacker offlinehacker merged commit 1bc95dc into NixOS:master Feb 7, 2019
10 checks passed

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@offlinehacker offlinehacker deleted the xtruder:pkgs/xsuspender/init branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.