Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccls: init at 0.20181225.7 #53888

Merged
merged 1 commit into from
Jan 16, 2019
Merged

ccls: init at 0.20181225.7 #53888

merged 1 commit into from
Jan 16, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 13, 2019

  • tested with emacs and vim on nix and systemd.
  • wrapped to pick up our cc wrapper environment -> works perfectly in nix-shell
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Jan 13, 2019

cc @tobim
@GrahamcOfBorg build ccls

@Mic92
Copy link
Member Author

Mic92 commented Jan 13, 2019

cc @dtzWill

@Mic92
Copy link
Member Author

Mic92 commented Jan 13, 2019

Looks like the release was deleted -> opened an upstream ticket: MaskRay/ccls#202

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jan 13, 2019
@Mic92
Copy link
Member Author

Mic92 commented Jan 13, 2019

@GrahamcOfBorg build ccls

'';

meta = with stdenv.lib; {
description = "A c/c++ language server powered by libclang";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is no longer powered by libclang (Clang C interface). It only uses Clang C++ APIs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much copy-pasta from cquery :)


stdenv.mkDerivation rec {
name = "ccls-${version}";
version = "0.20181225.6";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but if it didn't bother you much, could you please use the tag 0.20181225.7 ?

0.20181225.6 may cause unpleasant log lines in vscode and coc.nvim. MaskRay/ccls#205

meta = with stdenv.lib; {
description = "A c/c++ language server powered by libclang";
homepage = https://github.com/MaskRay/ccls;
license = licenses.mit;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is Apache 2. Every file has been rewritten.

- tested with [emacs](https://dl.thalheim.io/kdh-PwxzlwGKTEl1_NpTzg/2019-01-13-190156_1920x1080_scrot.png)
and vim.
- wrapped to pick up our cc wrapper environment -> works perfectly in nix-shell
@Mic92 Mic92 changed the title ccls: init at 0.20181225 ccls: init at 0.20181225.7 Jan 15, 2019
@Mic92
Copy link
Member Author

Mic92 commented Jan 15, 2019

@GrahamcOfBorg build ccls

@Mic92 Mic92 merged commit bb885d5 into NixOS:master Jan 16, 2019
@Mic92 Mic92 deleted the ccls branch January 16, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants