Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcc: 0.7.0 -> 0.8.0 #53907

Merged
merged 1 commit into from
Jan 27, 2019
Merged

bcc: 0.7.0 -> 0.8.0 #53907

merged 1 commit into from
Jan 27, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 13, 2019

Motivation for this change

Fix compat w/kernel 5.0, probably other things too (?).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jan 13, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Jan 14, 2019

Looks like bcc was broken when the BPF target stopped being included in LLVM (see ff22d90 for related fallout re:dropping AMDGPU target). Will issue PR to re-add it / discuss, shortly.

@dtzWill dtzWill merged commit 022c016 into NixOS:master Jan 27, 2019
@dtzWill dtzWill deleted the update/bcc-0.8.0 branch January 27, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants