Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-serif-pro: 1.017 -> 2.010, sync w/source-sans-pro expression #53915

Merged
merged 2 commits into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@dtzWill
Copy link
Contributor

commented Jan 13, 2019

Motivation for this change

Now installs font in various formats, not only OTF,
since that's what we do with source-sans-pro.

If this needs to be changed, we should fix that as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

Now installs font in various formats, not only OTF,
since that's what we do with source-sans-pro.

If this needs to be changed, we should fix that as well.

I think this is fine 👍

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

I think we should also change the homepage for these expression to like https://adobe-fonts.github.io/source-serif-pro/

source-{code,sans,serif}-pro: update homepage
Per reviewer suggestion on #53915.
@worldofpeace
Copy link
Member

left a comment

Should be good 👍

As long as this isn't already out of date that is 😄

@dtzWill

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

Doesn't seem to be! Quick, better merge before it becomes outdated! :P

@dtzWill dtzWill merged commit 7f6f22f into NixOS:master Jan 29, 2019

12 of 13 checks passed

source-serif-pro on x86_64-darwin
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
source-serif-pro on aarch64-linux Success
Details
source-serif-pro on x86_64-linux Success
Details

@dtzWill dtzWill deleted the dtzWill:update/source-serif-pro-2.010 branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.