-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glib.setupHook: fix gsettings-schemas location #54130
Conversation
GLib setup hook expects GSettings schemas to be installed in ${!outputLib} and tries to move them to gsettings-schemas/$name subdirectory to prevent conflicts. But the schemas will only end up in the library output when the build system recognizes makeFlags set by the setup hook, and in that case the move is not necessary, since the flag already includes the subdirectory. Normally, this is not an issue, since most packages relying on GSettings schemas either still use Autotools with gsettings.m4, or do not have a lib output set. But with the promulgation of multiple outputs in Nixpkgs and more and more projects switching to Meson, the issue will become increasingly common. We first noticed this problem with nm-applet. Closes NixOS#45043
Just tested building We depend on
I recall there was some patches to remove python from here. |
|
Yeah, the python bindings should be in a different package too. Do we even need them in nixpkgs? |
Or maybe we could switch to https://github.com/AyatanaIndicators/libayatana-appindicator like Debian is doing. |
I actually had some of the |
Motivation for this change
GLib setup hook expects GSettings schemas to be installed in
${!outputLib}
and tries to move them togsettings-schemas/$name
subdirectory to prevent conflicts. But the schemas will only end up in the library output when the build system recognizesmakeFlags
set by the setup hook, and in that case the move is not necessary, since the flag already includes the subdirectory.Normally, this is not an issue, since most packages relying on GSettings schemas either still use Autotools with
gsettings.m4
, or do not have a lib output set. But with the promulgation of multiple outputs in Nixpkgs and more and more projects switching to Meson, the issue will become increasingly common.We first noticed this problem with nm-applet.
Closes #45043
Things done
sandbox
innix.conf
on non-NixOS)cc @worldofpeace @hedning