Skip to content

xdg-desktop-portal-kde: fix missing dependencies #54133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

xdg-desktop-portal-kde: fix missing dependencies #54133

merged 1 commit into from
Jan 17, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

It didn't build due to missing dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg requested a review from ttuegel as a code owner January 17, 2019 00:27
@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build tests.plasma5

@GrahamcOfBorg GrahamcOfBorg added 6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 17, 2019
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build nixosTests.plasma5

@hedning hedning merged commit ee0d575 into NixOS:master Jan 17, 2019
@hedning hedning mentioned this pull request Jan 17, 2019
Closed
@peterhoeg peterhoeg deleted the f/portal_kde branch March 18, 2019 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterhoeg @worldofpeace @hedning @GrahamcOfBorg