Skip to content

qtxmlpatterns: fix dependency with qtdeclarative #54141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2019
Merged

qtxmlpatterns: fix dependency with qtdeclarative #54141

merged 1 commit into from
Jan 18, 2019

Conversation

acowley
Copy link
Contributor

@acowley acowley commented Jan 17, 2019

In Qt-5.12, the order of the dependency between these two packages
flipped.

A symptom of the problem is an error like, module "QtQuick.XmlListModel" is not installed.

The upstream changes that this reflects are in qtxmlpatterns
qt/qtxmlpatterns@8c6e243
and qtdeclarative qt/qtdeclarative@0477a05

Motivation for this change

I encountered this error in the KDE Plasma Weather Widget which stopped functioning after I updated, but I believe it occurs anywhere the XmlListModel module is used in QML.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@acowley
qtxmlpatterns: fix dependency with qtdeclarative
5fc5f15 
In Qt-5.12, the order of the dependency between these two packages
flipped.

A symptom of the problem is an error like, `module
"QtQuick.XmlListModel" is not installed`.

The upstream changes that this reflects are in qtxmlpatterns
<qt/qtxmlpatterns@8c6e243>
and qtdeclarative <qt/qtdeclarative@0477a05>
@acowley acowley requested a review from ttuegel as a code owner January 17, 2019 02:02
@GrahamcOfBorg GrahamcOfBorg added 6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jan 17, 2019
@acowley
Copy link
Contributor Author

acowley commented Jan 18, 2019

Ping @bkchr

bkchr
bkchr approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@hedning could you merge this?

@Mic92 Mic92 merged commit 4dc359c into NixOS:master Jan 18, 2019
@averelld averelld mentioned this pull request Jan 20, 2019
Merged
10 tasks
@acowley acowley deleted the qtxmlpatterns-fix branch January 21, 2019 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acowley @bkchr @Mic92 @GrahamcOfBorg