Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.sphinx-argparse: init at 0.2.5 #54233

Merged
merged 2 commits into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@clacke
Copy link
Contributor

commented Jan 18, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@clacke clacke force-pushed the clacke:sphinx-argparse branch from cea0c66 to 22695f5 Jan 24, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

commented Jan 26, 2019

@GrahamcOfBorg build python2.pkgs.sphinx-argparse python3.pkgs.sphinx-argparse

@dotlambda

This comment has been minimized.

Copy link
Member

commented Jan 26, 2019

Ran 0 tests in 0.000s

Please add an appropriate checkPhase or - if there are no tests - set doCheck = false and add a comment with the reason.

@dotlambda dotlambda changed the title python: sphinx-argparse: init at 0.2.5 pythonPackages.sphinx-argparse: init at 0.2.5 Jan 29, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

@clacke Please squash the new commits into the initial one.

@GrahamcOfBorg build python2.pkgs.sphinx-argparse python3.pkgs.sphinx-argparse

@clacke

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

Otherwise good?

@clacke clacke force-pushed the clacke:sphinx-argparse branch from c7f13ab to 5cc36ec Jan 29, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

@GrahamcOfBorg build python2.pkgs.sphinx-argparse python3.pkgs.sphinx-argparse

@dotlambda

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

We usually use commit messages formatted like this PR's title, but it's okay as it is.

@dotlambda dotlambda merged commit 99c025a into NixOS:master Jan 29, 2019

13 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python2.pkgs.sphinx-argparse, python3.pkgs.sphinx-argparse on aarch64-linux Success
Details
python2.pkgs.sphinx-argparse, python3.pkgs.sphinx-argparse on x86_64-darwin Success
Details
python2.pkgs.sphinx-argparse, python3.pkgs.sphinx-argparse on x86_64-linux Success
Details

@clacke clacke deleted the clacke:sphinx-argparse branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.