Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kak-lsp: init at 6.0.1 #54348

Closed
wants to merge 3 commits into from
Closed

kak-lsp: init at 6.0.1 #54348

wants to merge 3 commits into from

Conversation

@swdunlop
Copy link
Contributor

swdunlop commented Jan 20, 2019

Motivation for this change

enables language server protocol support for Kakoune

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning

This comment has been minimized.

Copy link
Contributor

hedning commented Jan 21, 2019

@GrahamcOfBorg build kak-lsp

@hedning hedning requested a review from vrthra Jan 21, 2019
@Infinisil

This comment has been minimized.

Copy link
Member

Infinisil commented Mar 29, 2019

  • Can you update the PR with the latest version 6.1.0?
  • Use rebasing for fixing conflicts instead of merging, no merge commits should be in the PR
  • What's a saml2aws update doing there? Should probably be moved to different PR unless it's relevant for this one
@aanderse

This comment has been minimized.

Copy link
Contributor

aanderse commented Aug 4, 2019

@swdunlop any motivation to continue with this PR?

@eraserhd

This comment has been minimized.

Copy link
Contributor

eraserhd commented Nov 11, 2019

This PR is out of date, as we have kak-lsp 7.0.0 merged already. Someone should close it.

@aanderse

This comment has been minimized.

Copy link
Contributor

aanderse commented Nov 11, 2019

@eraserhd thanks!

@aanderse aanderse closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.