Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fonttools: 3.34.2 -> 3.35.2 #54362

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@dtzWill
Copy link
Contributor

commented Jan 20, 2019

Motivation for this change
Things done

(but not on this exact branch, FWIW)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Member

left a comment

Commit msg should be pythonPackages.fonttools: 3.34.2 -> 3.35.2

Also I don't see a need for this to got to staging.

@dtzWill dtzWill force-pushed the dtzWill:update/fonttools-3.35.2 branch from 723ca71 to b038be0 Jan 20, 2019

@dtzWill dtzWill changed the base branch from staging to master Jan 21, 2019

@dtzWill dtzWill force-pushed the dtzWill:update/fonttools-3.35.2 branch from b038be0 to f2f5cad Jan 21, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

@GrahamcOfBorg build pythonPackages.fonttools python3Packages.fonttools

@dtzWill

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

Looks like I was too slow and it was updated to newer version in the meantime! haha oops :D.

@dtzWill dtzWill closed this Jan 29, 2019

@dtzWill dtzWill deleted the dtzWill:update/fonttools-3.35.2 branch Jan 29, 2019

@dtzWill dtzWill referenced this pull request Jan 29, 2019

Merged

pythonPackages.fonttools: 3.36.0 -> 3.37.0 #54869

2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.