Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages: remove some packages representing outdated versions #54462

merged 7 commits into from Jan 23, 2019


Copy link

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

Robert Schütz added 6 commits January 22, 2019 11:26
It is broken and no longer used.
It is no longer used.
A deprecation warning was removed in 427e749.
However, nixpkgs.tarball does evaluate without it now.
argparse is part of stdlib in 2.7 and 3.2+
@dotlambda dotlambda requested a review from FRidh as a code owner January 22, 2019 11:45
Copy link

FRidh commented Jan 22, 2019

Packages often still declare they depend on argparse so some patches might be needed.

Copy link
Member Author

We had argparse = null in python-packages.nix before. Hence, packages already had to provide patches.

Copy link
Member Author

@GrahamcOfBorg eval

Copy link
Member Author

nix-review only shows failures that are also on master.

@FRidh FRidh merged commit 01efca4 into NixOS:master Jan 23, 2019
@dotlambda dotlambda deleted the python-pkgs-remove branch January 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants