Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql: add restartTrigger for my.cnf #54475

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
4 participants
@Izorkin
Copy link
Contributor

commented Jan 22, 2019

Motivation for this change

Allow restart mysql.service on change config my.cnf

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -249,6 +249,7 @@ in

after = [ "network.target" ];
wantedBy = [ "multi-user.target" ];
restartTriggers = [ config.environment.etc."my.cnf".source ];

This comment has been minimized.

Copy link
@makefu

makefu Jan 29, 2019

Contributor

Is the variable working as you would expect? config.environment.etc."my.cnf".source points into /nix/store to a static file. It may work when you set restartIfChanged for te service.

I'd guess that /etc/my.cnf is the correct thing to put here, however i have not yet debugged restartTriggers.

This comment has been minimized.

Copy link
@Izorkin

Izorkin Jan 29, 2019

Author Contributor

Yes, I checked

This comment has been minimized.

This comment has been minimized.

Copy link
@makefu

makefu Jan 29, 2019

Contributor

Ah okay, restartTriggers (and therefore X-Restart-Triggers) is actually NixOS specific and a random commit in nixpkgs actually contains the documentation:

The triggers are just arbitrary strings that are included in the unit
under X-Restart-Triggers.  The idea is that if they change between
reconfigurations, switch-to-configuration will restart the unit
because its store path changed.  This is mostly useful for services
that implicitly depend on generated files in /etc.  Thus you can say

  restartTriggers = [ confFile ];

where ‘confFile’ is the derivation that generated the /etc file in
question.

b606165

@makefu

makefu approved these changes Jan 29, 2019

@Infinisil Infinisil merged commit 997cd31 into NixOS:master Jan 29, 2019

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Izorkin

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

Thanks!

@Izorkin Izorkin deleted the Izorkin:mysql-restartTrigger branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.