Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: sysconfig: fix paths #54486

merged 1 commit into from Feb 7, 2019


Copy link

Motivation for this change

#51668 nukes too much, and the out path can probably be excluded without much risk. This fixes reticulate in r-modules for example.

Can be verified via python -c'import sysconfig;print(sysconfig.get_config_var("LIBDIR"))'

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

Copy link

FRidh commented Jan 23, 2019

I agree that it seems to remove to much. This becomes especially noticeable when attempting cross-compilation. I'll have a look at this change later.

Copy link

ping @FRidh

Copy link

I tested the proposed pull request and it fixes the issue for me. Thank you @averelld.

I would welcome a quick merge as 2526f9f breaks Pythons sysconfig module fundamentally and as a result also any code using it.

Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

Copy link

@FRidh The broken patch has been in unstable for a while now and more and more people are hitting it. What is holding up the merge? Can we at least revert the initial patch and move on from there?

@FRidh FRidh merged commit 91aeda1 into NixOS:staging Feb 7, 2019
@averelld averelld deleted the python-sysconfig-fix branch February 7, 2019 22:51
@FlorianFranzen FlorianFranzen mentioned this pull request Feb 10, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

6 participants