New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: sysconfig: fix paths #54486

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
6 participants
@averelld
Copy link
Contributor

averelld commented Jan 22, 2019

Motivation for this change

#51668 nukes too much, and the out path can probably be excluded without much risk. This fixes reticulate in r-modules for example.

Can be verified via python -c'import sysconfig;print(sysconfig.get_config_var("LIBDIR"))'

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Averell Dalton
@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Jan 23, 2019

I agree that it seems to remove to much. This becomes especially noticeable when attempting cross-compilation. I'll have a look at this change later.

@dotlambda dotlambda referenced this pull request Jan 30, 2019

Merged

pythonPackages.scikit-build: init at 0.8.1 #54890

4 of 10 tasks complete
@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 30, 2019

ping @FRidh

@FlorianFranzen

This comment has been minimized.

Copy link
Contributor

FlorianFranzen commented Jan 30, 2019

I tested the proposed pull request and it fixes the issue for me. Thank you @averelld.

I would welcome a quick merge as 2526f9f breaks Pythons sysconfig module fundamentally and as a result also any code using it.

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Feb 7, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/cannot-link-against-python/2054/2

@FlorianFranzen

This comment has been minimized.

Copy link
Contributor

FlorianFranzen commented Feb 7, 2019

@FRidh The broken patch has been in unstable for a while now and more and more people are hitting it. What is holding up the merge? Can we at least revert the initial patch and move on from there?

@FRidh FRidh merged commit 91aeda1 into NixOS:staging Feb 7, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@averelld averelld deleted the averelld:python-sysconfig-fix branch Feb 7, 2019

@FlorianFranzen FlorianFranzen referenced this pull request Feb 10, 2019

Merged

Staging next #54306

0 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment