Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37Packages.cryptography{,_vectors}: 2.4.2 -> 2.5 #54488

merged 2 commits into from Feb 14, 2019


Copy link

@primeos primeos commented Jan 22, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits


Important changes:
- BACKWARDS INCOMPATIBLE: U-label strings were deprecated in version
  2.1, but this version removes the default idna dependency as well.
- BACKWARDS INCOMPATIBLE: The minimum supported PyPy version is now 5.4.
Copy link
Member Author

primeos commented Feb 13, 2019

@FRidh will you merge this when ready or should I do it?

I did rebuild all Python packages after opening this PR to make sure there are no failures due to pinned versions (2.4.x) or a missing idna dependency and I also ran a few manual checks. I didn't notice anything problematic and assume that this should be fine, at least mostly (though I obviously cannot guarantee it).

@FRidh FRidh merged commit ecfa775 into NixOS:staging Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants