Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zxing-cpp: init at git-20180320 #54572

Closed
wants to merge 1 commit into from
Closed

Conversation

@voobscout
Copy link
Contributor

voobscout commented Jan 25, 2019

This port takes considerably less space in nix store,
usecases: containers, squashfs, iso images

Motivation for this change

When storage space is at a premium, like a netboot image, this helps by not requiring java deps.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This port takes considerably less space in nix store,
usecases: containers, squashfs, iso images
sha256 = "07xshbh656a26bi8bii6ffw3fahnfj6755f6ybmmmplk55xxnlg8";
};

nativeBuildInputs = [ pkgconfig cmake makeWrapper ];

This comment has been minimized.

Copy link
@symphorien

symphorien Jan 25, 2019

Contributor

makeWrapper seems unused

};

nativeBuildInputs = [ pkgconfig cmake makeWrapper ];
cmakeFlags = [ "-DCMAKE_BUILD_TYPE=Release" ];

This comment has been minimized.

Copy link
@symphorien

symphorien Jan 25, 2019

Contributor

Apparently this is unnecessary:

cmakeFlags="-DCMAKE_BUILD_TYPE=${cmakeBuildType:-Release} -DCMAKE_SKIP_BUILD_RPATH=ON $cmakeFlags"

@7c6f434c
Copy link
Member

7c6f434c commented Jan 25, 2019

(tried to search for ZXing-cpp) argh, apparently there are multiple forks of ZXing C++ code around, with apparently unrelated further development histories.

Do we want to disambiguate/prevent future ambiguity?

@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

Are there any updates on this pull request, please?

@doronbehar
Copy link
Contributor

doronbehar commented May 16, 2020

I'm closing as OP has no intention to comment or fix the issues raised in review.

@doronbehar doronbehar closed this May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.