Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagemagick: add djvu support #54592

Merged
merged 1 commit into from Feb 6, 2019
Merged

imagemagick: add djvu support #54592

merged 1 commit into from Feb 6, 2019

Conversation

@pacien
Copy link
Contributor

@pacien pacien commented Jan 25, 2019

Motivation for this change

This enables support for the DJVU format in ImageMagick.
It is used in gscan2pdf (PR #54434) for instance.

I tested the registration of the library with ImageMagick 6 on NixOS 18.09 and gscan2pdf.
I haven't tested ImageMagick 7 though.

I'm also unsure whether this dependency should be put in propagatedBuildInputs instead of buildInputs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@veprbl veprbl left a comment

You need to look into updating imagemagick_light and imagemagick7_light attributes.

@pacien pacien force-pushed the imagemagick-djvu branch from 3eaed78 to 84f4d77 Jan 25, 2019
@pacien
Copy link
Contributor Author

@pacien pacien commented Jan 25, 2019

You need to look into updating imagemagick_light and imagemagick7_light attributes.

Amended.

@pacien
Copy link
Contributor Author

@pacien pacien commented Feb 5, 2019

Up? This blocks #54434.

@veprbl
Copy link
Member

@veprbl veprbl commented Feb 5, 2019

@GrahamcOfBorg build imagemagick7 imagemagick7_light imagemagick7Big
@GrahamcOfBorg build imagemagick imagemagick_light imagemagickBig

veprbl
veprbl approved these changes Feb 6, 2019
Copy link
Member

@veprbl veprbl left a comment

nix-review gave no new build failures compared to what's already failing on Hydra

@veprbl veprbl merged commit 87d8ba0 into NixOS:master Feb 6, 2019
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants