Skip to content

treewide: remove wkennington as maintainer #54619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2019
Merged

treewide: remove wkennington as maintainer #54619

merged 1 commit into from
Jan 26, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 26, 2019

He prefers to contribute to his own nixpkgs fork triton.
Since he is still marked as maintainer in many packages
this leaves the wrong impression he still maintains those.

@Mic92
treewide: remove wkennington as maintainer
b5c1dec 
He prefers to contribute to his own nixpkgs fork triton.
Since he is still marked as maintainer in many packages
this leaves the wrong impression he still maintains those.
@Mic92 Mic92 requested a review from LnL7 as a code owner January 26, 2019 10:07
@danbst
Copy link
Contributor

danbst commented Jan 26, 2019

should he be removed from org as well?

@Mic92
Copy link
Member Author

Mic92 commented Jan 26, 2019

Might be a good idea, @domenkozar ?

@Mic92
Copy link
Member Author

Mic92 commented Jan 26, 2019

@GrahamcOfBorg eval

@GrahamcOfBorg GrahamcOfBorg added 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 26, 2019
@domenkozar
Copy link
Member

No need to remove him from the org I think. Maintainership makes sense though.

grahamc
grahamc approved these changes Jan 26, 2019
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shame to see many packages without maintainers.

@infinisil
Copy link
Member

Ping @wkennington

@wkennington
Copy link
Contributor

Looks good to me

@Mic92 Mic92 merged commit ba34ffc into NixOS:master Jan 26, 2019
@Mic92 Mic92 deleted the remove-wkennington branch January 26, 2019 23:38
@erictapen erictapen mentioned this pull request Jan 27, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Mic92 @danbst @domenkozar @infinisil @wkennington @grahamc @GrahamcOfBorg