Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultGemConfig.rbczmq: init #54640

Merged
merged 1 commit into from
Jan 27, 2019
Merged

defaultGemConfig.rbczmq: init #54640

merged 1 commit into from
Jan 27, 2019

Conversation

alyssais
Copy link
Member

Motivation for this change

Fixes nix-community/bundix#42.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @MMesch

@alyssais alyssais requested a review from zimbatm as a code owner January 26, 2019 21:16
@GrahamcOfBorg GrahamcOfBorg added 6.topic: ruby 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 26, 2019
@alyssais alyssais merged commit 9c2c5ee into NixOS:master Jan 27, 2019
@alyssais alyssais deleted the rbczmq branch January 27, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alyssais @zimbatm @GrahamcOfBorg