Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.sh: put SHELL in flagsArray #54652

Merged
merged 1 commit into from
Jan 27, 2019
Merged

setup.sh: put SHELL in flagsArray #54652

merged 1 commit into from
Jan 27, 2019

Conversation

matthewbauer
Copy link
Member

We don’t want to modify makeFlags, that is given to us by our
environment. Adding to it could lead to duplicates after repeated use.

Fixes #27533

@matthewbauer
setup.sh: put SHELL in flagsArray
329913f 
We don’t want to modify makeFlags, that is given to us by our
environment. Adding to it could lead to duplicates after repeated use.

Fixes NixOS#27533
@GrahamcOfBorg GrahamcOfBorg added 6.topic: stdenv Standard environment 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ labels Jan 27, 2019
@matthewbauer matthewbauer changed the base branch from master to staging January 27, 2019 03:40
@GrahamcOfBorg GrahamcOfBorg added 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: ruby 6.topic: rust 6.topic: vim 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 27, 2019
@matthewbauer matthewbauer changed the base branch from staging to master January 27, 2019 05:02
@matthewbauer matthewbauer changed the base branch from master to staging January 27, 2019 05:02
@GrahamcOfBorg GrahamcOfBorg removed 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: ruby 6.topic: rust 6.topic: vim 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Jan 27, 2019
@GrahamcOfBorg GrahamcOfBorg removed 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 27, 2019
@matthewbauer matthewbauer merged commit bd62ac6 into NixOS:staging Jan 27, 2019
@matthewbauer matthewbauer deleted the shell-in-flags-array branch February 22, 2019 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewbauer @GrahamcOfBorg